Commit 5cf5f93d authored by Khosrow Ebrahimpour's avatar Khosrow Ebrahimpour

db parameters can now be passed db_parameter_group mode

parent 0750cc1c
...@@ -49,6 +49,17 @@ module "db" { ...@@ -49,6 +49,17 @@ module "db" {
# DB parameter group # DB parameter group
family = "mysql5.7" family = "mysql5.7"
parameters = [
{
name = "character_set_client"
value = "utf8"
},
{
name = "character_set_server"
value = "utf8"
}
]
} }
``` ```
......
...@@ -21,7 +21,7 @@ module "db_parameter_group" { ...@@ -21,7 +21,7 @@ module "db_parameter_group" {
name_prefix = "${var.identifier}-" name_prefix = "${var.identifier}-"
family = "${var.family}" family = "${var.family}"
// parameter = ["${var.parameters}"] parameters = ["${var.parameters}"]
tags = "${var.tags}" tags = "${var.tags}"
} }
......
...@@ -8,26 +8,7 @@ resource "aws_db_parameter_group" "this" { ...@@ -8,26 +8,7 @@ resource "aws_db_parameter_group" "this" {
description = "Database parameter group for ${var.identifier}" description = "Database parameter group for ${var.identifier}"
family = "${var.family}" family = "${var.family}"
// @todo: implement this parameter = ["${var.parameters}"]
// parameter = ["${var.parameters}"]
// parameter = [
// {
// name = "character_set_server"
// value = "utf8"
// },
// {
// name = "character_set_client"
// value = "utf18"
// },
// ]
parameter {
name = "character_set_server"
value = "utf8"
}
parameter {
name = "character_set_client"
value = "utf8"
}
tags = "${merge(var.tags, map("Name", format("%s", var.identifier)))}" tags = "${merge(var.tags, map("Name", format("%s", var.identifier)))}"
} }
...@@ -16,9 +16,8 @@ variable "family" { ...@@ -16,9 +16,8 @@ variable "family" {
} }
variable "parameters" { variable "parameters" {
type = "map" description = "A list of DB parameter maps to apply"
description = "A map of lists of DB parameters to apply" default = []
default = {}
} }
variable "tags" { variable "tags" {
......
...@@ -126,7 +126,6 @@ variable "family" { ...@@ -126,7 +126,6 @@ variable "family" {
} }
variable "parameters" { variable "parameters" {
type = "map" description = "A list of DB parameters (map) to apply"
description = "A map of lists of DB parameters to apply" default = []
default = {}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment