Merge pull request #2 from khosrow/master

db parameters can now be passed to db_parameter_group module

README.md

@@ -49,6 +49,17 @@ module "db" {
   
   # DB parameter group
   family = "mysql5.7"
+
+  parameters = [
+    { 
+      name = "character_set_client"
+      value = "utf8"
+    },
+    { 
+      name = "character_set_server"
+      value = "utf8"
+    }
+  ]
 }
 ```
 

main.tf

@@ -21,7 +21,7 @@ module "db_parameter_group" {
   name_prefix = "${var.identifier}-"
   family      = "${var.family}"
 
-  //  parameter = ["${var.parameters}"]
+  parameters = ["${var.parameters}"]
 
   tags = "${var.tags}"
 }

modules/db_parameter_group/main.tf

@@ -8,26 +8,7 @@ resource "aws_db_parameter_group" "this" {
   description = "Database parameter group for ${var.identifier}"
   family      = "${var.family}"
 
-  // @todo: implement this
-  //  parameter = ["${var.parameters}"]
+  parameter = ["${var.parameters}"]
 
-  //  parameter = [
-  //    {
-  //      name  = "character_set_server"
-  //      value = "utf8"
-  //    },
-  //    {
-  //      name  = "character_set_client"
-  //      value = "utf18"
-  //    },
-  //  ]
-  parameter {
-    name  = "character_set_server"
-    value = "utf8"
-  }
-  parameter {
-    name  = "character_set_client"
-    value = "utf8"
-  }
   tags = "${merge(var.tags, map("Name", format("%s", var.identifier)))}"
 }

modules/db_parameter_group/variables.tf

@@ -16,9 +16,8 @@ variable "family" {
 }
 
 variable "parameters" {
-  type        = "map"
-  description = "A map of lists of DB parameters to apply"
-  default     = {}
+  description = "A list of DB parameter maps to apply"
+  default     = []
 }
 
 variable "tags" {

variables.tf

@@ -126,7 +126,6 @@ variable "family" {
 }
 
 variable "parameters" {
-  type        = "map"
-  description = "A map of lists of DB parameters to apply"
-  default     = {}
+  description = "A list of DB parameters (map) to apply"
+  default     = []
 }