chore: Updated versions&comments in examples

examples/basic/README.md

@@ -38,7 +38,7 @@ Note that this example may create resources which can cost money. Run `terraform
 | <a name="module_ec2_with_t2_unlimited"></a> [ec2\_with\_t2\_unlimited](#module\_ec2\_with\_t2\_unlimited) | ../../ |  |
 | <a name="module_ec2_with_t3_unlimited"></a> [ec2\_with\_t3\_unlimited](#module\_ec2\_with\_t3\_unlimited) | ../../ |  |
 | <a name="module_ec2_zero"></a> [ec2\_zero](#module\_ec2\_zero) | ../../ |  |
-| <a name="module_security_group"></a> [security\_group](#module\_security\_group) | terraform-aws-modules/security-group/aws | ~> 3.0 |
+| <a name="module_security_group"></a> [security\_group](#module\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
 
 ## Resources
 

examples/basic/main.tf

@@ -44,7 +44,7 @@ data "aws_ami" "amazon_linux" {
 
 module "security_group" {
   source  = "terraform-aws-modules/security-group/aws"
-  version = "~> 3.0"
+  version = "~> 4.0"
 
   name        = "example"
   description = "Security group for example usage with EC2 instance"
@@ -84,7 +84,7 @@ module "ec2" {
   instance_type = "c5.large"
   subnet_id     = tolist(data.aws_subnet_ids.all.ids)[0]
   #  private_ips                 = ["172.31.32.5", "172.31.46.20"]
-  vpc_security_group_ids      = [module.security_group.this_security_group_id]
+  vpc_security_group_ids      = [module.security_group.security_group_id]
   associate_public_ip_address = true
   placement_group             = aws_placement_group.web.id
 
@@ -124,7 +124,7 @@ module "ec2_with_t2_unlimited" {
   cpu_credits   = "unlimited"
   subnet_id     = tolist(data.aws_subnet_ids.all.ids)[0]
   #  private_ip = "172.31.32.10"
-  vpc_security_group_ids      = [module.security_group.this_security_group_id]
+  vpc_security_group_ids      = [module.security_group.security_group_id]
   associate_public_ip_address = true
 }
 
@@ -138,7 +138,7 @@ module "ec2_with_t3_unlimited" {
   instance_type               = "t3.large"
   cpu_credits                 = "unlimited"
   subnet_id                   = tolist(data.aws_subnet_ids.all.ids)[0]
-  vpc_security_group_ids      = [module.security_group.this_security_group_id]
+  vpc_security_group_ids      = [module.security_group.security_group_id]
   associate_public_ip_address = true
 }
 
@@ -151,7 +151,7 @@ module "ec2_with_metadata_options" {
   ami                         = data.aws_ami.amazon_linux.id
   instance_type               = "t2.small"
   subnet_id                   = tolist(data.aws_subnet_ids.all.ids)[0]
-  vpc_security_group_ids      = [module.security_group.this_security_group_id]
+  vpc_security_group_ids      = [module.security_group.security_group_id]
   associate_public_ip_address = true
 
   metadata_options = {
@@ -190,5 +190,5 @@ module "ec2_zero" {
   ami                    = data.aws_ami.amazon_linux.id
   instance_type          = "c5.large"
   subnet_id              = tolist(data.aws_subnet_ids.all.ids)[0]
-  vpc_security_group_ids = [module.security_group.this_security_group_id]
+  vpc_security_group_ids = [module.security_group.security_group_id]
 }

examples/volume-attachment/README.md

@@ -37,14 +37,14 @@ Note that this example may create resources which can cost money. Run `terraform
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_ec2"></a> [ec2](#module\_ec2) | ../../ |  |
-| <a name="module_security_group"></a> [security\_group](#module\_security\_group) | terraform-aws-modules/security-group/aws | ~> 3.0 |
+| <a name="module_security_group"></a> [security\_group](#module\_security\_group) | terraform-aws-modules/security-group/aws | ~> 4.0 |
 
 ## Resources
 
 | Name | Type |
 |------|------|
 | [aws_ebs_volume.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ebs_volume) | resource |
-| [aws_volume_attachment.this_ec2](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/volume_attachment) | resource |
+| [aws_volume_attachment.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/volume_attachment) | resource |
 | [aws_ami.amazon_linux](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ami) | data source |
 | [aws_subnet_ids.all](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnet_ids) | data source |
 | [aws_vpc.default](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/vpc) | data source |

examples/volume-attachment/main.tf

@@ -37,7 +37,7 @@ data "aws_ami" "amazon_linux" {
 
 module "security_group" {
   source  = "terraform-aws-modules/security-group/aws"
-  version = "~> 3.0"
+  version = "~> 4.0"
 
   name        = "example"
   description = "Security group for example usage with EC2 instance"
@@ -57,11 +57,11 @@ module "ec2" {
   ami                         = data.aws_ami.amazon_linux.id
   instance_type               = "c5.large"
   subnet_id                   = tolist(data.aws_subnet_ids.all.ids)[0]
-  vpc_security_group_ids      = [module.security_group.this_security_group_id]
+  vpc_security_group_ids      = [module.security_group.security_group_id]
   associate_public_ip_address = true
 }
 
-resource "aws_volume_attachment" "this_ec2" {
+resource "aws_volume_attachment" "this" {
   count = var.instances_number
 
   device_name = "/dev/sdh"

examples/volume-attachment/outputs.tf

@@ -5,11 +5,11 @@ output "instances_public_ips" {
 
 output "ebs_volume_attachment_id" {
   description = "The volume ID"
-  value       = aws_volume_attachment.this_ec2.*.volume_id
+  value       = aws_volume_attachment.this.*.volume_id
 }
 
 output "ebs_volume_attachment_instance_id" {
   description = "The instance ID"
-  value       = aws_volume_attachment.this_ec2.*.instance_id
+  value       = aws_volume_attachment.this.*.instance_id
 }