Added performance_insights support (#139)

.pre-commit-config.yaml

@@ -3,7 +3,7 @@ repos:
   rev: v1.17.0
   hooks:
     - id: terraform_fmt
-#    - id: terraform_docs
+    - id: terraform_docs
 - repo: git://github.com/pre-commit/pre-commit-hooks
   rev: v2.2.3
   hooks:

main.tf

@@ -93,6 +93,8 @@ module "db_instance" {
   copy_tags_to_snapshot       = var.copy_tags_to_snapshot
   final_snapshot_identifier   = var.final_snapshot_identifier
 
+  performance_insights_enabled = var.performance_insights_enabled
+
   backup_retention_period = var.backup_retention_period
   backup_window           = var.backup_window
 

modules/db_instance/README.md

@@ -6,49 +6,50 @@
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | allocated\_storage | The allocated storage in gigabytes | string | n/a | yes |
-| allow\_major\_version\_upgrade | Indicates that major version upgrades are allowed. Changing this parameter does not result in an outage and the change is asynchronously applied as soon as possible | string | `"false"` | no |
-| apply\_immediately | Specifies whether any database modifications are applied immediately, or during the next maintenance window | string | `"false"` | no |
-| auto\_minor\_version\_upgrade | Indicates that minor engine upgrades will be applied automatically to the DB instance during the maintenance window | string | `"true"` | no |
+| allow\_major\_version\_upgrade | Indicates that major version upgrades are allowed. Changing this parameter does not result in an outage and the change is asynchronously applied as soon as possible | bool | `"false"` | no |
+| apply\_immediately | Specifies whether any database modifications are applied immediately, or during the next maintenance window | bool | `"false"` | no |
+| auto\_minor\_version\_upgrade | Indicates that minor engine upgrades will be applied automatically to the DB instance during the maintenance window | bool | `"true"` | no |
 | availability\_zone | The Availability Zone of the RDS instance | string | `""` | no |
-| backup\_retention\_period | The days to retain backups for | string | `"1"` | no |
+| backup\_retention\_period | The days to retain backups for | number | `"1"` | no |
 | backup\_window | The daily time range (in UTC) during which automated backups are created if they are enabled. Example: '09:46-10:16'. Must not overlap with maintenance_window | string | n/a | yes |
 | character\_set\_name | (Optional) The character set name to use for DB encoding in Oracle instances. This can't be changed. See Oracle Character Sets Supported in Amazon RDS for more information | string | `""` | no |
-| copy\_tags\_to\_snapshot | On delete, copy all Instance tags to the final snapshot (if final_snapshot_identifier is specified) | string | `"false"` | no |
-| create | Whether to create this resource or not? | string | `"true"` | no |
-| create\_monitoring\_role | Create IAM role with a defined name that permits RDS to send enhanced monitoring metrics to CloudWatch Logs. | string | `"false"` | no |
+| copy\_tags\_to\_snapshot | On delete, copy all Instance tags to the final snapshot (if final_snapshot_identifier is specified) | bool | `"false"` | no |
+| create | Whether to create this resource or not? | bool | `"true"` | no |
+| create\_monitoring\_role | Create IAM role with a defined name that permits RDS to send enhanced monitoring metrics to CloudWatch Logs. | bool | `"false"` | no |
 | db\_subnet\_group\_name | Name of DB subnet group. DB instance will be created in the VPC associated with the DB subnet group. If unspecified, will be created in the default VPC | string | `""` | no |
-| deletion\_protection | The database can't be deleted when this value is set to true. | string | `"false"` | no |
-| enabled\_cloudwatch\_logs\_exports | List of log types to enable for exporting to CloudWatch logs. If omitted, no logs will be exported. Valid values (depending on engine): alert, audit, error, general, listener, slowquery, trace, postgresql (PostgreSQL), upgrade (PostgreSQL). | list | `<list>` | no |
+| deletion\_protection | The database can't be deleted when this value is set to true. | bool | `"false"` | no |
+| enabled\_cloudwatch\_logs\_exports | List of log types to enable for exporting to CloudWatch logs. If omitted, no logs will be exported. Valid values (depending on engine): alert, audit, error, general, listener, slowquery, trace, postgresql (PostgreSQL), upgrade (PostgreSQL). | list(string) | `[]` | no |
 | engine | The database engine to use | string | n/a | yes |
 | engine\_version | The engine version to use | string | n/a | yes |
-| final\_snapshot\_identifier | The name of your final DB snapshot when this DB instance is deleted. | string | `"false"` | no |
-| iam\_database\_authentication\_enabled | Specifies whether or mappings of AWS Identity and Access Management (IAM) accounts to database accounts is enabled | string | `"false"` | no |
+| final\_snapshot\_identifier | The name of your final DB snapshot when this DB instance is deleted. | string | `"null"` | no |
+| iam\_database\_authentication\_enabled | Specifies whether or mappings of AWS Identity and Access Management (IAM) accounts to database accounts is enabled | bool | `"false"` | no |
 | identifier | The name of the RDS instance, if omitted, Terraform will assign a random, unique identifier | string | n/a | yes |
 | instance\_class | The instance type of the RDS instance | string | n/a | yes |
-| iops | The amount of provisioned IOPS. Setting this implies a storage_type of 'io1' | string | `"0"` | no |
+| iops | The amount of provisioned IOPS. Setting this implies a storage_type of 'io1' | number | `"0"` | no |
 | kms\_key\_id | The ARN for the KMS encryption key. If creating an encrypted replica, set this to the destination KMS ARN. If storage_encrypted is set to true and kms_key_id is not specified the default KMS key created in your account will be used | string | `""` | no |
 | license\_model | License model information for this DB instance. Optional, but required for some DB engines, i.e. Oracle SE1 | string | `""` | no |
 | maintenance\_window | The window to perform maintenance in. Syntax: 'ddd:hh24:mi-ddd:hh24:mi'. Eg: 'Mon:00:00-Mon:03:00' | string | n/a | yes |
-| monitoring\_interval | The interval, in seconds, between points when Enhanced Monitoring metrics are collected for the DB instance. To disable collecting Enhanced Monitoring metrics, specify 0. The default is 0. Valid Values: 0, 1, 5, 10, 15, 30, 60. | string | `"0"` | no |
+| monitoring\_interval | The interval, in seconds, between points when Enhanced Monitoring metrics are collected for the DB instance. To disable collecting Enhanced Monitoring metrics, specify 0. The default is 0. Valid Values: 0, 1, 5, 10, 15, 30, 60. | number | `"0"` | no |
 | monitoring\_role\_arn | The ARN for the IAM role that permits RDS to send enhanced monitoring metrics to CloudWatch Logs. Must be specified if monitoring_interval is non-zero. | string | `""` | no |
 | monitoring\_role\_name | Name of the IAM role which will be created when create_monitoring_role is enabled. | string | `"rds-monitoring-role"` | no |
-| multi\_az | Specifies if the RDS instance is multi-AZ | string | `"false"` | no |
+| multi\_az | Specifies if the RDS instance is multi-AZ | bool | `"false"` | no |
 | name | The DB name to create. If omitted, no database is created initially | string | `""` | no |
 | option\_group\_name | Name of the DB option group to associate. | string | `""` | no |
 | parameter\_group\_name | Name of the DB parameter group to associate | string | `""` | no |
 | password | Password for the master DB user. Note that this may show up in logs, and it will be stored in the state file | string | n/a | yes |
+| performance\_insights\_enabled | Specifies whether Performance Insights are enabled | bool | `"false"` | no |
 | port | The port on which the DB accepts connections | string | n/a | yes |
-| publicly\_accessible | Bool to control if instance is publicly accessible | string | `"false"` | no |
+| publicly\_accessible | Bool to control if instance is publicly accessible | bool | `"false"` | no |
 | replicate\_source\_db | Specifies that this resource is a Replicate database, and to use this value as the source database. This correlates to the identifier of another Amazon RDS Database to replicate. | string | `""` | no |
-| skip\_final\_snapshot | Determines whether a final DB snapshot is created before the DB instance is deleted. If true is specified, no DBSnapshot is created. If false is specified, a DB snapshot is created before the DB instance is deleted, using the value from final_snapshot_identifier | string | `"true"` | no |
+| skip\_final\_snapshot | Determines whether a final DB snapshot is created before the DB instance is deleted. If true is specified, no DBSnapshot is created. If false is specified, a DB snapshot is created before the DB instance is deleted, using the value from final_snapshot_identifier | bool | `"true"` | no |
 | snapshot\_identifier | Specifies whether or not to create this database from a snapshot. This correlates to the snapshot ID you'd find in the RDS console, e.g: rds:production-2015-06-26-06-05. | string | `""` | no |
-| storage\_encrypted | Specifies whether the DB instance is encrypted | string | `"false"` | no |
+| storage\_encrypted | Specifies whether the DB instance is encrypted | bool | `"false"` | no |
 | storage\_type | One of 'standard' (magnetic), 'gp2' (general purpose SSD), or 'io1' (provisioned IOPS SSD). The default is 'io1' if iops is specified, 'standard' if not. Note that this behaviour is different from the AWS web console, where the default is 'gp2'. | string | `"gp2"` | no |
-| tags | A mapping of tags to assign to all resources | map | `<map>` | no |
-| timeouts | (Optional) Updated Terraform resource management timeouts. Applies to `aws_db_instance` in particular to permit resource management times | map | `<map>` | no |
+| tags | A mapping of tags to assign to all resources | map(string) | `{}` | no |
+| timeouts | (Optional) Updated Terraform resource management timeouts. Applies to `aws_db_instance` in particular to permit resource management times | map(string) | `{ "create": "40m", "delete": "40m", "update": "80m" }` | no |
 | timezone | (Optional) Time zone of the DB instance. timezone is currently only supported by Microsoft SQL Server. The timezone can only be set on creation. See MSSQL User Guide for more information. | string | `""` | no |
 | username | Username for the master DB user | string | n/a | yes |
-| vpc\_security\_group\_ids | List of VPC security groups to associate | list | `<list>` | no |
+| vpc\_security\_group\_ids | List of VPC security groups to associate | list(string) | `[]` | no |
 
 ## Outputs
 

modules/db_instance/main.tf

@@ -80,6 +80,8 @@ resource "aws_db_instance" "this" {
   copy_tags_to_snapshot       = var.copy_tags_to_snapshot
   final_snapshot_identifier   = var.final_snapshot_identifier
 
+  performance_insights_enabled = var.performance_insights_enabled
+
   backup_retention_period = var.backup_retention_period
   backup_window           = var.backup_window
 
@@ -147,6 +149,8 @@ resource "aws_db_instance" "this_mssql" {
   copy_tags_to_snapshot       = var.copy_tags_to_snapshot
   final_snapshot_identifier   = var.final_snapshot_identifier
 
+  performance_insights_enabled = var.performance_insights_enabled
+
   backup_retention_period = var.backup_retention_period
   backup_window           = var.backup_window
 

modules/db_instance/variables.tf

@@ -255,3 +255,9 @@ variable "deletion_protection" {
   type        = bool
   default     = false
 }
+
+variable "performance_insights_enabled" {
+  description = "Specifies whether Performance Insights are enabled"
+  type        = bool
+  default     = false
+}

modules/db_option_group/README.md

@@ -5,14 +5,14 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| create | Whether to create this resource or not? | string | `"true"` | no |
+| create | Whether to create this resource or not? | bool | `"true"` | no |
 | engine\_name | Specifies the name of the engine that this option group should be associated with | string | n/a | yes |
 | identifier | The identifier of the resource | string | n/a | yes |
 | major\_engine\_version | Specifies the major version of the engine that this option group should be associated with | string | n/a | yes |
 | name\_prefix | Creates a unique name beginning with the specified prefix | string | n/a | yes |
 | option\_group\_description | The description of the option group | string | `""` | no |
-| options | A list of Options to apply | list | `<list>` | no |
-| tags | A mapping of tags to assign to the resource | map | `<map>` | no |
+| options | A list of Options to apply | any | `[]` | no |
+| tags | A mapping of tags to assign to the resource | map(string) | `{}` | no |
 
 ## Outputs
 

modules/db_parameter_group/README.md

@@ -5,15 +5,15 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| create | Whether to create this resource or not? | string | `"true"` | no |
+| create | Whether to create this resource or not? | bool | `"true"` | no |
 | description | The description of the DB parameter group | string | `""` | no |
 | family | The family of the DB parameter group | string | n/a | yes |
 | identifier | The identifier of the resource | string | n/a | yes |
 | name | The name of the DB parameter group | string | `""` | no |
 | name\_prefix | Creates a unique name beginning with the specified prefix | string | `""` | no |
-| parameters | A list of DB parameter maps to apply | list | `<list>` | no |
-| tags | A mapping of tags to assign to the resource | map | `<map>` | no |
-| use\_name\_prefix | Whether to use name_prefix or not | string | `"true"` | no |
+| parameters | A list of DB parameter maps to apply | list(map(string)) | `[]` | no |
+| tags | A mapping of tags to assign to the resource | map(string) | `{}` | no |
+| use\_name\_prefix | Whether to use name_prefix or not | bool | `"true"` | no |
 
 ## Outputs
 

modules/db_subnet_group/README.md

@@ -5,11 +5,11 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| create | Whether to create this resource or not? | string | `"true"` | no |
+| create | Whether to create this resource or not? | bool | `"true"` | no |
 | identifier | The identifier of the resource | string | n/a | yes |
 | name\_prefix | Creates a unique name beginning with the specified prefix | string | n/a | yes |
-| subnet\_ids | A list of VPC subnet IDs | list | `<list>` | no |
-| tags | A mapping of tags to assign to the resource | map | `<map>` | no |
+| subnet\_ids | A list of VPC subnet IDs | list(string) | `[]` | no |
+| tags | A mapping of tags to assign to the resource | map(string) | `{}` | no |
 
 ## Outputs
 

variables.tf

@@ -325,3 +325,8 @@ variable "use_parameter_group_name_prefix" {
   default     = true
 }
 
+variable "performance_insights_enabled" {
+  description = "Specifies whether Performance Insights are enabled"
+  type        = bool
+  default     = false
+}